This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Implement all known blink::PointerData fields on iOS. #3955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Aug 4, 2017
| // Discussion: | ||
| // Sweep direction is the same. Phase of M_PI_2. | ||
| pointer_data.orientation = [touch azimuthAngleInView:nil] - M_PI_2; | ||
| } |
Member
|
LGTM The license file needs to be updated for platform_version |
xster
approved these changes
Aug 7, 2017
|
|
||
| // pressure_min is always 0.0 | ||
| if (_platformSupportsTouchPressure) { | ||
| // These properties were introduced in iOS 9.0. |
Member
There was a problem hiding this comment.
should we add these version limitations to pointer_data.h or pointer.dart?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds all the appropriate runtime version checks. I am not able to test the stylus altitude and azimuth readings because I don't have one (can we get one please). I have tried to match documented behavior though.