Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Feb 10, 2023

Cherry-pick #39516

Request at flutter/flutter#120478

@jmagman jmagman self-assigned this Feb 10, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jmagman jmagman changed the title Revert "Remove deprecated TextInputClient scribble method code" (#39516) Revert "Remove deprecated TextInputClient scribble method code" Feb 10, 2023
@jmagman jmagman requested a review from justinmc February 10, 2023 20:17
@jmagman jmagman changed the title Revert "Remove deprecated TextInputClient scribble method code" [cp] Revert "Remove deprecated TextInputClient scribble method code" Feb 10, 2023
@theniceboy

This comment was marked as duplicate.

@jmagman
Copy link
Member Author

jmagman commented Feb 13, 2023

…ter#39516)

Fixes the scribble feature (iPad handwriting input via Apple Pencil).
@jmagman
Copy link
Member Author

jmagman commented Feb 14, 2023

Rebasing on #39597

@jmagman jmagman requested a review from chinmaygarde February 14, 2023 23:59
@jmagman
Copy link
Member Author

jmagman commented Feb 14, 2023

I think @justinmc is OOO, @chinmaygarde can you review this since you also reviewed #39516 ?

@jmagman
Copy link
Member Author

jmagman commented Feb 15, 2023

@itsjustkevin the request flutter/flutter#120478 is approved, am I good to merge this or does the release team do that?

@itsjustkevin itsjustkevin merged commit 4c002d2 into flutter:flutter-3.7-candidate.1 Feb 15, 2023
@jmagman jmagman deleted the cp-scribble-revert branch February 22, 2023 21:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants