This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fixes related to usage of std::weak_ptr to hold PlatformViews #3949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jason-simmons
commented
Aug 3, 2017
jason-simmons
commented
- Call weak_ptr.lock(), which returns a null shared_ptr and does not throw
- IsViewInvalid was inverted
* Call weak_ptr.lock(), which returns a null shared_ptr and does not throw * IsViewInvalid was inverted
Member
Author
chinmaygarde
approved these changes
Aug 3, 2017
B3rn475
approved these changes
Aug 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.