Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jason-simmons
Copy link
Member

@jason-simmons
Copy link
Member Author

@chinmaygarde

@Hixie
Copy link
Contributor

Hixie commented Jul 31, 2017

test?

@jason-simmons
Copy link
Member Author

We don't currently have a testing environment for Android Java code

@jason-simmons jason-simmons merged commit f02a30b into flutter:master Jul 31, 2017
@eseidelGoogle
Copy link
Contributor

Do we need up and down for multi-line text? (or any other directions?) :)

@Hixie
Copy link
Contributor

Hixie commented Aug 1, 2017

Can we add a testing environment for Android Java code? I feel like "we don't have a test environment" should not be an excuse for not writing tests, it should be a reason for us to block further development until we have a test environment.

@jason-simmons
Copy link
Member Author

I don't know if any IMEs expose up or down soft keys. Up and down will be trickier because the text plugin can't just increment/decrement the selection - it will need to calculate the position of the text above or below the current cursor.

@Hixie
Copy link
Contributor

Hixie commented Aug 1, 2017

Are these APIs async? If so, we might want to just do all the work in Dart, so we can re-use the same logic for iOS and Android, and minimize the work we have to do (and test) in the engine.

@ds84182
Copy link
Contributor

ds84182 commented Aug 7, 2017

GBoard for Android supports up and down navigation. Hit the G at the top left and tap <I>.

Currently Up, Down, Home, End, and Selection are unimplemented. See flutter/flutter#9419

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants