This repository was archived by the owner on Feb 25, 2025. It is now read-only.
When the surface does not support SRGB, render to an offscreen texture. #3930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shell/gpu/gpu_surface_gl.cc
Outdated
| } | ||
|
|
||
| if (!onscreen_surface_supports_sgrb_) { | ||
| // Because the surface did not support SRGB, we rendered offscreen surface. |
Member
There was a problem hiding this comment.
rendered to an offscreen surface
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the prototype, the offscreen rendering is managed at the platform agnostic layer. This version is also able to survive context loss and resizes.
If the surface supports SRGB (determined via platform specific checks), rendering canvas will be backed by a surface that wraps the platform FBO. If not, an offscreen surface will be created and a copy performed onscreen per present.
I still have to fix the following but this patch is good for review: