This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use the x64 toolchain when building host artifacts on arm64 mac #39279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @godofredoc |
cbracken
reviewed
Jan 31, 2023
| # for macOS (see the logic below), pass the flag "--mac-cpu arm64". | ||
| # https://github.com/flutter/flutter/issues/103386 is also relevant here. | ||
| if get_host_os() == 'mac' and not args.mac_cpu == 'arm64': | ||
| gn_args['host_cpu'] = 'x64' |
Member
There was a problem hiding this comment.
Haven't I already covered this for host builds in lines 356-360?
Member
Author
There was a problem hiding this comment.
I simplified the logic, and with the simpler logic, hopefully the comment makes more sense now. PTAL.
zanderso
force-pushed
the
mac-host-cpu-x64
branch
from
7b1915a to
2af0dea
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 1, 2023
…119741) * 30ba71efa Roll Skia from 8f33da33edcf to 4b5799677173 (1 revision) (flutter/engine#39318) * 0de70dbe5 Use the x64 toolchain when building host artifacts on arm64 mac (flutter/engine#39279) * 4fc0a0297 Update README.md (flutter/engine#39319) * bae377499 Roll Skia from 4b5799677173 to 86f7b2dd2b4f (8 revisions) (flutter/engine#39320) * ba3adb74d Roll Dart SDK from 88d1f3ffa266 to b47964e5d575 (1 revision) (flutter/engine#39321)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to use arm64 macs in CI, and for the reasons noted in the comment.