Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jonahwilliams
Copy link
Contributor

  • Fix position of ImageFilter layer when raster-cached

  • Move integral transform and add tests

  • Don't round in Preroll

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

* Fix position of ImageFilter layer when raster-cached

* Move integral transform and add tests

* Don't round in Preroll
@zanderso
Copy link
Member

Presubs failing on flutter/flutter#119519

@XilaiZhang
Copy link
Contributor

XilaiZhang commented Jan 31, 2023

clicked rerun for the 10 ish failed presubmits. Will come back and check if they pass
update: looks like majority of presub tests are passing now, except a few known flakes, will deflake.
update: all checks passing now. once other batches of cps finish post submit I will merge in this one as the final cp.

@XilaiZhang XilaiZhang merged commit 55b8f0f into flutter:flutter-3.7-candidate.1 Jan 31, 2023
@jonahwilliams jonahwilliams deleted the fix_thingy branch January 31, 2023 05:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants