This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Incorporate the device pixel ratio when drawing shadows #3919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Contributor
jvanverth
reviewed
Jul 24, 2017
Contributor
jvanverth
left a comment
jvanverth
left a comment
There was a problem hiding this comment.
physical_model_layer changes look good to me.
chinmaygarde
approved these changes
Jul 24, 2017
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
LGTM after renaming the instance variable.
flow/layers/physical_model_layer.h
Outdated
| SkRRect rrect_; | ||
| float elevation_; | ||
| SkColor color_; | ||
| SkScalar dpr_; |
Member
There was a problem hiding this comment.
Let's call this device_pixel_ratio_ instead for readability.
jason-simmons
force-pushed
the
shadow_view_metrics
branch
from
6704163 to
89bda9f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.