This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll Skia and enable API guards #3884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jul 17, 2017
Member
|
Hey @brianosman, I you are blocked or too frustrated to deal with debugging the licenses, I can attempt to sort through and land this. Let me know. Thanks. |
Contributor
|
Looks like nothing changed license-wise except the list of files, so you can just apply the patch in the Travis output to your local copy and submit that. |
Contributor
Author
|
That would be great. I started with a brand new engine directory checkout,
and I still can't get my local license script output to match what the CI
is expecting. (Not sure why, I haven't had issues like this in a long
time...)
…On Jul 17, 2017 5:37 PM, "Chinmay Garde" ***@***.***> wrote:
Hey @brianosman <https://github.com/brianosman>, I you are blocked or too
frustrated to deal with debugging the licenses, I can attempt to sort
through and land this. Let me know. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3884 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ARkhnrduK03j0P13FQCMn1fkqGEltHSiks5sO9QagaJpZM4Oagou>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking over from #3881...