This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add Flutter defines option to GN for Skia #3877
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jul 14, 2017
Contributor
Author
|
One question: Because this modifies the gn helper script, it's not going to automatically re-generate if people just build with ninja (users will need to explicitly rerun flutter/tools/gn). Is that okay? |
Contributor
Author
|
Subsumed by #3881 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once https://skia-review.googlesource.com/c/23042/ lands (and is rolled), this gives us the ability to stage Skia API changes in a similar manner to other clients. In the meantime, this will trigger a GN warning about an arg that isn't declared by any GN file.