This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add flutter-driven navigation on iOS #3865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobr-google
approved these changes
Jul 12, 2017
| [((UINavigationController*)viewController) popViewControllerAnimated:NO]; | ||
| } | ||
|
|
||
| } |
Contributor
There was a problem hiding this comment.
Nit: This one probably shouldn't be indented.
| "framework/Headers/FlutterMacros.h", | ||
| "framework/Headers/FlutterPlugin.h", | ||
| "framework/Headers/FlutterViewController.h", | ||
| "framework/Headers/FlutterNavigationController.h", |
Contributor
There was a problem hiding this comment.
I believe you'll need to add the new files to some licenses index file as well. Travis would know for sure.
Contributor
|
Can we test this? |
Contributor
|
@szakarias is this still being worked on? If not, can we close it in the meantime, so that it is removed from the review queue? |
Contributor
Author
|
I'll merge this tomorrow CEST. I'm working on a test for it in a follow-up PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.