This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "Run Flutter on iOS and Android with color correct Skia #3826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Is this okay to land? I'm guessing yes - it's the same as last week's, except it actually compiles everywhere. |
Contributor
|
@chinmaygarde or @jason-simmons are the most appropriate reviewers for this PR. |
chinmaygarde
approved these changes
Jun 27, 2017
collinjackson
added a commit
to collinjackson/engine
that referenced
this pull request
Jul 13, 2017
flutter#3826)" This reverts commit 2d9155e. Fixes a regression with semitransparent images (flutter/flutter#11169)
collinjackson
added a commit
that referenced
this pull request
Jul 13, 2017
#3826)" (#3878) This reverts commit 2d9155e. Fixes a regression with semitransparent images (flutter/flutter#11169)
brianosman
added a commit
that referenced
this pull request
Jul 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt at #3818, #3776. This is identical to the #3818, plus compile fixes for the test code that I forgot to update. Now both host and target builds succeed.