LGTM

licenses_golden/licenses_third_party needs to be updated

Okay. I'm just going to wait for our infra team to double-check Fuschia.

You'll need to update the licenses again, sorry. I just checked in a change that will invalidate the licenses update you did.

It looks like this introduced a regression in shadow rendering. See the following animation of the before and after effects on card shadows:

I can't tell which of those are better? @jvanverth

The corners of the cards look off to me, but I'm by no means an expert :-)

This might be related to the changes I made to tweak colored shadows. I'll take a look.

Here's how it affects rounded shadows:

Another example:

vs this other one:

Is this running on software or GPU?

My screenshots were running on GPU (iPhone 7 plus device).

My screenshots are from:

GLES: Google (VMware, Inc.), Android Emulator OpenGL ES Translator (Gallium 0.4 on llvmpipe (LLVM 3.5, 256 bits)), OpenGL ES 2.0 (3.0 Mesa 10.4.2 (git-))

Thanks, that probably means it's not the geometric shadow cache. We made a lot of changes since the last time you've rolled so it's not clear which one could have caused it. I'll do a bisect and see what I can figure out.

This doesn't require a roll back does it? This roll fixed a couple of issues.

No, the changes are small enough that we can fix forward.

I plugged in your lighting code into my test app and I'm not seeing any difference between the last roll and the current one. My guess is that this either has something to do with SKP playback (which I'm not sure if you're using or not) and/or the pixel ratio. The lighting code in PhysicalModelLayer doesn't seem to take the pixel ratio into account, which on higher-res displays could cause the sharpening you're seeing.

Sounds like it's time to move this conversation into a new bug. :) @tvolkert would you do the honor?

Filed flutter/flutter#11035