This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Improve the names of Flutter processes. #3819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abarth
reviewed
Jun 23, 2017
content_handler/app.cc
Outdated
| void App::UpdateProcessLabel() { | ||
| std::string label = base_label_; | ||
| if (controllers_.size() >= 2) { | ||
| label += " (+" + std::to_string(controllers_.size() - 1) + ")"; |
Contributor
There was a problem hiding this comment.
If the label would overflow with the added part, I'd truncate the label to MX_MAX_NAME_LEN - suffix.size() - 3 and then append "..." + suffix. :)
Contributor
There was a problem hiding this comment.
I'd also do that in the case where controllers_.size() < 2, but obviously suffix would be empty in that case.
Contributor
|
|
ianloic
reviewed
Jun 23, 2017
| if (controllers_.size() >= 2) { | ||
| label += " (+" + std::to_string(controllers_.size() - 1) + ")"; | ||
| } | ||
| mx::process::self().set_property(MX_PROP_NAME, label.c_str(), label.size()); |
Contributor
There was a problem hiding this comment.
The kernel will truncate the name at MX_MAX_NAME_LEN - 1. Maybe there should be logic to truncate the base_label_ rather that losing the number of additional apps?
pylaligand
force-pushed
the
process_names
branch
2 times, most recently
from
93dd183 to
c6ae158
Compare
Contributor
|
LGTM. Do you want to add this logic to //apps/dart_runner too? If not I can copy & paste it myself. |
pylaligand
force-pushed
the
process_names
branch
from
c6ae158 to
62d1f94
Compare
Contributor
Author
|
Go for it :) |
Contributor
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.