This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "Run Flutter on iOS and Android with color correct Skia" #3818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
@chinmaygarde Can we try to land this and see how the bots react? We've done many local tests on iPhone 6, and haven't had any trouble. |
chinmaygarde
approved these changes
Jun 23, 2017
Member
Sound good to me! |
Contributor
|
Have we tested simulators? Those were also affected by the last attempt. |
Contributor
|
(And are not yet tested by our infrastructure.) |
Contributor
|
The black screen on the Android emulator flutter/flutter#10617 is fixed by ef90bc7. The original change was tested on iOS simulator. |
Contributor
|
Great! |
brianosman
added a commit
that referenced
this pull request
Jun 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking over #3776 from matt. This include the revert of the revert, the 4444 fix, and also a fix to the IO thread's context creation. We weren't doing uploads on that thread, so we didn't notice the bug (Skia wasn't checking for the GL_APPLE_sync extension). Skia has been fixed, so once it rolls the uploads should be on the other thread.
I've found the same thing that Matt did - switching to naked pointers fixes the iPhone6 reboots, but we can't explain it. I'm trying to figure out what happened, but getting tempted to land it - perhaps we get more useful errors or feedback from the bots if there's still a problem?