This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Catch exceptions during invocations of updateSemantics from native code #3813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
goderbauer
approved these changes
Jun 22, 2017
| } | ||
| } | ||
|
|
||
| // Called by native to update the semantics/accessibility tree. |
Member
There was a problem hiding this comment.
What's "native" in this case? I thought the Java stuff is native?
Member
Author
There was a problem hiding this comment.
It's called from the engine's C++ code via JNI
Contributor
There was a problem hiding this comment.
we should just say that. treat "native" as a "bad word", it's too confusing :-)
tvolkert
approved these changes
Jun 22, 2017
Hixie
reviewed
Jun 22, 2017
| mAccessibilityNodeProvider.updateSemantics(buffer, strings); | ||
| } | ||
| } catch (Exception ex) { | ||
| Log.e(TAG, "Uncaught exception while updating semantics", ex); |
Contributor
There was a problem hiding this comment.
Are there exceptions that are ever actually expected? What are the exceptions we're seeing?
Contributor
|
@Hixie see internal bug 62860749 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.