Only add Fuchsia-specific stuff when the current OS is Fuchsia. #3809
Conversation
lib/snapshot/BUILD.gn
Outdated
| import("//flutter/lib/ui/dart_ui.gni") | ||
|
|
||
| target_is_fuchsia = target_os == "fuchsia" | ||
| target_is_fuchsia = target_os == "fuchsia" && current_os == target_os |
There was a problem hiding this comment.
should probably just be current_os == "fuchsia"
There was a problem hiding this comment.
Yes. If we were building on Fuchsia and targeting, say, Windows, then we'd want to use the Fuchsia stuff for the host OS.
This allows the shell to be built normally for a Fuchsia host.
|
So, this patch seems fine, but I'm not sure why this helps you. This will let you build a shell on the host system that is capable of running Flutter apps that are built for non-Fuchsia platforms. If your goal is to test Flutter apps that are built for Fuchsia, then this host binary will be missing the Fuchsia-specific built-in libraries. |
|
The present change only affects the generated Flutter content handler, not the apps. In order to build and analyze Flutter apps built for Fuchsia, I already needed to put workarounds in place such as https://github.com/flutter/flutter/blob/master/packages/flutter/BUILD.gn#L22. The reason why I needed this change is that the generate_package_map rule ended up pulling the Flutter Dart package for the host, and that version did not properly link to sky_engine and made analysis fail. Another way to fix this would be to add |
|
Ok. LGTM |
3 participants
This allows the shell to be built normally for a Fuchsia host.