This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Do not call restartInput twice when setting a new text input client. #3808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If restartInput is called twice in quick succession, then the IME may output warnings related to usage of the obsolete connection resulting from the first call. Fixes flutter/flutter#10730
Member
Author
Member
|
|
Contributor
|
Can this be tested? |
Member
Author
|
AFAIK we don't have a good solution for unit testing of Android Java code in the engine |
Contributor
|
Can we use existing Java unit test frameworks to do it? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If restartInput is called twice in quick succession, then the IME may output
warnings related to usage of the obsolete connection resulting from the first
call.
Fixes flutter/flutter#10730