This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Update switches to use StringView. #3781
Merged
+10
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jun 16, 2017
Contributor
|
This broke Mac and Linux. |
Contributor
Author
|
Not cool. Where can I see the breakage? |
Contributor
Author
|
I see what the problem is: I need to update the version of the FTL Flutter uses. |
Contributor
Author
|
I don't quite understand why Travis did not have a problem with this PR though. |
Contributor
|
Travis doesn't build the engine. |
pylaligand
added a commit
that referenced
this pull request
Jun 16, 2017
This reverts commit 07d4357.
pylaligand
added a commit
that referenced
this pull request
Jun 16, 2017
* Revert "Initial integration of libtxt with Flutter alongside Blink. (#3771)" This reverts commit c548c65. * Revert "Call Selection.removeSelection if the framework has cleared the selection (#3782)" This reverts commit e5b79ba. * Revert "Update switches to use StringView. (#3781)" This reverts commit 07d4357.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://fuchsia-review.googlesource.com/#/c/31931/.