-
Notifications
You must be signed in to change notification settings - Fork 6k
Reland "Run Flutter on iOS and Android with color correct Skia" #3776
Conversation
|
Still some things to work out before landing this... |
|
We should really make sure to find a way to automatically test emulators (e.g. in our devicelab) before we land this patch again, so that we can make sure we can catch the problems that we missed last time. |
|
(@yjbanov is the right person to speak to about how to do that.) |
|
Well, the devicelab caught the iPhone reboots. It's just that it took us some time to realize those were reboots. For emulator testing the tracking issue is flutter/flutter#10718. |
|
@brianosman will be taking ownership of this, but I've uploaded a third commit per a conversation with @chinmaygarde - in case it is a useful test to look at when setting up instrumented builds. The iOS reboots (flutter/flutter#10710) occur with the first two commits, but are strangely fixed by the third one "Use bare ptr to SkColorSpace on PrerollContext struct". |
|
@mattsarett what was the original motivation behind switching to bare pointers? |
|
Nothing in particular. In chasing this bug around, Brian and I noticed that it seemed to be triggered by the changes to flow/, in particular by plumbing the SkColorSpace through to the raster cache. We currently don't have a logical explanation for why this helps. |
|
With @mattsarett leaving, I'm planning to take over this PR. I've got my own version that includes the first two commits from this, plus another bugfix at #3818. |
flutter/flutter#10710
flutter/flutter#10617
flutter/flutter#8152
@brianosman