Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@mattsarett
Copy link
Contributor

@mattsarett
Copy link
Contributor Author

Still some things to work out before landing this...

@Hixie
Copy link
Contributor

Hixie commented Jun 15, 2017

We should really make sure to find a way to automatically test emulators (e.g. in our devicelab) before we land this patch again, so that we can make sure we can catch the problems that we missed last time.

@Hixie
Copy link
Contributor

Hixie commented Jun 19, 2017

(@yjbanov is the right person to speak to about how to do that.)

@yjbanov
Copy link
Contributor

yjbanov commented Jun 19, 2017

Well, the devicelab caught the iPhone reboots. It's just that it took us some time to realize those were reboots. For emulator testing the tracking issue is flutter/flutter#10718.

@mattsarett
Copy link
Contributor Author

@brianosman will be taking ownership of this, but I've uploaded a third commit per a conversation with @chinmaygarde - in case it is a useful test to look at when setting up instrumented builds.

The iOS reboots (flutter/flutter#10710) occur with the first two commits, but are strangely fixed by the third one "Use bare ptr to SkColorSpace on PrerollContext struct".

@yjbanov
Copy link
Contributor

yjbanov commented Jun 22, 2017

@mattsarett what was the original motivation behind switching to bare pointers?

@mattsarett
Copy link
Contributor Author

Nothing in particular. In chasing this bug around, Brian and I noticed that it seemed to be triggered by the changes to flow/, in particular by plumbing the SkColorSpace through to the raster cache. We currently don't have a logical explanation for why this helps.

@brianosman
Copy link
Contributor

With @mattsarett leaving, I'm planning to take over this PR. I've got my own version that includes the first two commits from this, plus another bugfix at #3818.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants