Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@goderbauer
Copy link
Member

This reverts commit ffe8181.

This commit seems to consistently cause the flutter_gallery_ios__transition_perf benchmark to crash on certain iOS devices (confirmed on a 6th-gen iPod Touch with iOS 10.3.1 and at least two iPhone 6 with iOS 10.3.2).

@tvolkert
Copy link
Contributor

FYI @mattsarett

@tvolkert
Copy link
Contributor

The commit being rolled back was also implicated as the cause of flutter/flutter#10617

@jason-simmons

@goderbauer goderbauer merged commit cfe70e0 into flutter:master Jun 14, 2017
mattsarett added a commit to mattsarett/engine that referenced this pull request Jun 15, 2017
brianosman added a commit that referenced this pull request Jun 24, 2017
* Revert "Revert "Run Flutter on iOS and Android with color correct Skia (#3743)" (#3775)"

This reverts commit cfe70e0.

* Enable sRGB on IO thread, too

* Add 4444 as a fallback rendering mode

* Use bare ptr to SkColorSpace (not sk_sp) in PrerollContext
@goderbauer goderbauer deleted the revert branch July 7, 2017 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants