This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove felt snapshotting behavior. #37639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
eyebrowsoffire
added
the
autosubmit
lib/web_ui/dev/felt
Outdated
| $DART_SDK_DIR/bin/dart $FELT_DEBUG_FLAGS --packages="$WEB_UI_DIR/.dart_tool/package_config.json" "$SNAPSHOT_PATH" $@ | ||
| fi | ||
| install_deps | ||
| $DART_SDK_DIR/bin/dart $FELT_DEBUG_FLAGS --packages="$WEB_UI_DIR/.dart_tool/package_config.json" "$SCRIPT_PATH" $@ |
Contributor
There was a problem hiding this comment.
If we use dart run could we avoid install_deps and needing to pass the --packages directly? https://dart.dev/tools/dart-run
Contributor
Author
There was a problem hiding this comment.
It looks like even with dart run I have to run install_deps first (it doesn't seem like dart run pulls dependencies. But I can change over to dart run to remove the need for the --packages stuff.
eyebrowsoffire
removed
the
autosubmit
mdebbar
approved these changes
Nov 15, 2022
eyebrowsoffire
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 16, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 16, 2022
…115406) * 6563c5843 Remove felt snapshotting behavior. (flutter/engine#37639) * c6e556489 Update language version in flutter_frontend_server/test/fixtures (flutter/engine#37643) * eedb93eb7 Update text editing tests (flutter/engine#37642) * a1dd33540 colorFilter as imageFilter for web (flutter/engine#37522) * b74c2c57a Remove usage of deprecated Fuchsia event source (flutter/engine#37641) * e56ed93fa Revert "Update text editing tests (#37642)" (flutter/engine#37653)
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
* Remove felt snapshotting behavior. * Use `dart run`.
godofredoc
added a commit
that referenced
this pull request
Nov 16, 2022
* clang-tidy: added the ability to shard jobs (#37265) * clang-tidy: added the ability to shard jobs * added test * jenn feedback * hack ci to run as a shard to measure the time * tweak * fix hack * zach feedback * zach feedback 2 * removed stray async * moved to using sets for lookups * fixed typo in docstring * Revert "fix hack" This reverts commit 06a61a6. Revert "tweak" This reverts commit e7c58b1. Revert "hack ci to run as a shard to measure the time" This reverts commit e458963. * removed calls to map * turned the ci hack back on * Revert "turned the ci hack back on" This reverts commit 0d53794. * removed sync* * Clang-tidy: Fixed math on shard-id validator. (#37433) Clang-tidy: Fixed math on shard-id validator. * Felt analyze (#37481) * Adding `felt analyze` command that CI will run. * Remove some copypasta'd stuff. * Also remove code path from felt.dart that forces a rebuild if it doesn't detect the host_debug_unopt directory. * More cleanup of felt.bat for CI. * Fix typo in felt.bat. * Run pub get before building host.dart. (#37502) * Run pub get before building host.dart. * We should call `pub get` for `web_ui` in the launcher script because felt itself needs it. However, we should let felt invoke `pub get` on `web_engine_tester` only as needed, not in the launcher script. * Skip the skwasm unit test suite on Safari since it is flaky. (#37602) * Skip the skwasm unit test suite on Safari since it is flaky. * Add TODO. * Remove felt snapshotting behavior. (#37639) * Remove felt snapshotting behavior. * Use `dart run`. * Combine results of all the test batches. (#37610) * Combine results of all the test batches. * Skip regressions * Use bool instead * remove unused var * skip fragment_program_test * Also skip GL context lost test * Transparent background test fails on Firefox and Safari * Skip other test in safari * Skip text test on firefox Co-authored-by: gaaclarke <[email protected]> Co-authored-by: Jackson Gardner <[email protected]> Co-authored-by: Harry Terkelsen <[email protected]>
mdebbar
added a commit
that referenced
this pull request
Dec 1, 2022
We don't do Dart snapshots anymore (since #37639).
auto-submit bot
pushed a commit
that referenced
this pull request
Dec 2, 2022
We don't do Dart snapshots anymore (since #37639).
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#115406) * 6563c5843 Remove felt snapshotting behavior. (flutter/engine#37639) * c6e556489 Update language version in flutter_frontend_server/test/fixtures (flutter/engine#37643) * eedb93eb7 Update text editing tests (flutter/engine#37642) * a1dd33540 colorFilter as imageFilter for web (flutter/engine#37522) * b74c2c57a Remove usage of deprecated Fuchsia event source (flutter/engine#37641) * e56ed93fa Revert "Update text editing tests (flutter#37642)" (flutter/engine#37653)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#115406) * 6563c5843 Remove felt snapshotting behavior. (flutter/engine#37639) * c6e556489 Update language version in flutter_frontend_server/test/fixtures (flutter/engine#37643) * eedb93eb7 Update text editing tests (flutter/engine#37642) * a1dd33540 colorFilter as imageFilter for web (flutter/engine#37522) * b74c2c57a Remove usage of deprecated Fuchsia event source (flutter/engine#37641) * e56ed93fa Revert "Update text editing tests (flutter#37642)" (flutter/engine#37653)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.