This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Log to stdout on all platforms except Android #3739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a Fuchsia breakage introduced in dcfcc92.
Hixie
reviewed
Jun 5, 2017
lib/ui/dart_runtime_hooks.cc
Outdated
| // On iOS and in flutter_tester (on both macOS and Linux, write directly to | ||
| // stdout. On iOS, this is redirected to ASL via | ||
| #else | ||
| // On Fuchsia, iOS and in flutter_tester (on both macOS and Linux, write |
Hixie
reviewed
Jun 5, 2017
lib/ui/dart_runtime_hooks.cc
Outdated
| // On Fuchsia, iOS and in flutter_tester (on both macOS and Linux, write | ||
| // directly to stdout. On iOS, this is redirected to ASL via | ||
| // RedirectIOConnectionsToSyslog in platform_mac.mm. | ||
| // TODO(cbracken) replace with dedicated (non-stdout) logging on iOS. |
Contributor
There was a problem hiding this comment.
nit: missing colon after ) in TODO
Contributor
|
|
Contributor
|
is there any way to test this? |
Member
Author
|
Will ask what our options are re: getting a Fuchsia chromebot, and what such a setup would look like. |
Member
Author
|
Fixes flutter/flutter#10509 |
This was referenced Nov 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a Fuchsia breakage introduced in
dcfcc92.