This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Simplify log forwarding on iOS, Android #3726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminates logging to stdout on Android -- now using __android_log_print only. Eliminates logging to syslog on iOS -- now writing to stdout with the existing ASL redirection (from platform_mac.mm) only. syslog() wasn't ever picked up in logs. This patch is a pre-factoring change before swapping out iOS engine logging to a flutter-specific mechanism.
chinmaygarde
approved these changes
Jun 2, 2017
Member
Author
|
First in a set of fixes for: flutter/flutter#10358, flutter/flutter#6758, flutter/flutter#8981, flutter/flutter#9308 |
This was referenced Nov 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates logging to stdout on Android -- now using __android_log_print
only.
Eliminates logging to syslog on iOS -- now writing to stdout with the
existing ASL redirection (from platform_mac.mm) only. syslog() wasn't
ever picked up in logs.
This patch is a pre-factoring change to reduce the change introduced in
the followup, which switches (iOS) engine logging to a flutter-specific
mechanism.