Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Build ios with goma. #37246

Merged
auto-submit merged 1 commit into from
Nov 2, 2022
Merged

Build ios with goma. #37246

auto-submit merged 1 commit into from
Nov 2, 2022

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Nov 2, 2022

The configurations were passing no-goma explicitly to the gn command which was disabling the use of goma.

Bug: flutter/flutter#114477

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Build ios with goma.
532e109 
The configurations were passing no-goma explicitly to the gn command
which was disabling the use of goma.

Bug: flutter/flutter#114477
@godofredoc godofredoc requested a review from zanderso November 2, 2022 17:12
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 2, 2022
@auto-submit auto-submit bot merged commit 2f293a3 into flutter:main Nov 2, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 2, 2022
@engine-flutter-autoroll
2f293a37b Build ios with goma. (flutter/engine#37246)
d7c5e7e
@godofredoc godofredoc deleted the remove_explicit_no_goma branch November 2, 2022 21:18
@godofredoc godofredoc mentioned this pull request Nov 4, 2022
Closed
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
@godofredoc @schwa423
Build ios with goma. (flutter#37246)
23edff0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@godofredoc @zanderso