Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Add shared tests for ui.Path #37222

Merged
harryterkelsen merged 7 commits into from
Nov 2, 2022
Merged

[web] Add shared tests for ui.Path #37222

harryterkelsen merged 7 commits into from
Nov 2, 2022

Conversation

@harryterkelsen
Copy link
Contributor

@harryterkelsen harryterkelsen commented Nov 1, 2022

Adds shared tests for ui.Path to the UI test suite.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Nov 1, 2022
mdebbar
mdebbar approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@mdebbar mdebbar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call setUpUiTest() in lib/web_ui/test/ui/title_test.dart?

@harryterkelsen
Copy link
Contributor Author

harryterkelsen commented Nov 1, 2022

Call setUpUiTest() in lib/web_ui/test/ui/title_test.dart?

done

@skia-gold
Copy link

skia-gold commented Nov 1, 2022

Gold has detected about 6 new digest(s) on patchset 5.
View them at https://flutter-engine-gold.skia.org/cl/github/37222

@skia-gold
Copy link

skia-gold commented Nov 1, 2022

Gold has detected about 6 new digest(s) on patchset 6.
View them at https://flutter-engine-gold.skia.org/cl/github/37222

@harryterkelsen harryterkelsen merged commit d9b9674 into flutter:main Nov 2, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 2, 2022
@engine-flutter-autoroll
d9b9674bf [web] Add shared tests for ui.Path (flutter/engine#37222)
80a1979
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
@schwa423
[web] Add shared tests for ui.Path (flutter#37222)
8020f43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yjbanov yjbanov Awaiting requested review from yjbanov

1 more reviewer

@mdebbar mdebbar mdebbar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-web Code specifically for the web engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@harryterkelsen @skia-gold @mdebbar