This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix Skia includes of SkEncodedImageFormat et al #37201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Nov 1, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 1, 2022
pull bot
pushed a commit
to TheRakeshPurohit/skia
that referenced
this pull request
Nov 1, 2022
Client changes: - http://cl/484581917 - http://cl/484583432 - https://crrev.com/c/3991332 - flutter/engine#37201 Change-Id: If3ab1fa72c333cbf4696be76e75c46c5b9c41ee3 Bug: skia:13052 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/597559 Reviewed-by: Ben Wagner <[email protected]> Owners-Override: Kevin Lubick <[email protected]>
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://skia-review.googlesource.com/c/skia/+/597559, Skia is changing an #include to a forward declare in a public header. This requires some Flutter files to include that file directly instead of depending on the (now removed) transitive include.
While I was fixing up these files, I made a few pre-emptive fixes of these missing includes.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on [Discord].