This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Run Flutter on iOS and Android with color correct Skia #3716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@chinmaygarde Can you take a look at this? Also, which backend is used by the iOS simulator? Is it important to update that in this PR as well? |
chinmaygarde
approved these changes
Jun 5, 2017
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Oh wow. Sorry for late response. I am not sure how I missed the GitHub notification. My bad.
LGTM. iOS uses the software backend on the emulators (
). You may update it in this patch or a later one if you wish.Thanks again for helping out on this.
Contributor
Author
|
Thanks Chinmay! I'll follow up on iOS simulator in a separate CL. I was having some trouble getting the simulator to run with a local engine build before. |
chinmaygarde
added a commit
that referenced
this pull request
Jun 5, 2017
This reverts commit fe82757.
mattsarett
added a commit
to mattsarett/engine
that referenced
this pull request
Jun 6, 2017
***Turns on color correct rendering for Android and iOS ***Communicates dst color space to raster cache ***Turns on color space aware image decoding Test: ***color_testing_demo on Pixel XL ***flutter_gallery on iPad Mini and iPad Pro (haven't figured out how to run manual_tests on iOS) TODO: I needed to split up this CL somewhere. These are follow-up tasks. ***Make desktop backends color correct ***Make debugging tools (ex: encoding frames to png) preserve color space ***Investigate using UIKit API to allow iOS to fine tune color space of rendered content
mattsarett
added a commit
that referenced
this pull request
Jun 9, 2017
* Run Flutter on iOS and Android with color correct Skia (#3716) ***Turns on color correct rendering for Android and iOS ***Communicates dst color space to raster cache ***Turns on color space aware image decoding Test: ***color_testing_demo on Pixel XL ***flutter_gallery on iPad Mini and iPad Pro (haven't figured out how to run manual_tests on iOS) TODO: I needed to split up this CL somewhere. These are follow-up tasks. ***Make desktop backends color correct ***Make debugging tools (ex: encoding frames to png) preserve color space ***Investigate using UIKit API to allow iOS to fine tune color space of rendered content
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
***Turns on color correct rendering for Android and iOS
***Communicates dst color space to raster cache
***Turns on color space aware image decoding
Test:
***color_testing_demo on Pixel XL
***flutter_gallery on iPad Mini and iPad Pro (haven't figured out how to run manual_tests on iOS)
TODO:
I needed to split up this CL somewhere. These are follow-up tasks.
***Make desktop backends color correct (Does iOS simulator run on one of these?)
***Make debugging tools (ex: encoding frames to png) preserve color space
***Investigate using UIKit API to allow iOS to fine tune color space of rendered content
CCing @brianosman @liyuqian so more skia people are in the loop.