Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@Nayuta403
Copy link
Contributor

@Nayuta403 Nayuta403 commented Oct 28, 2022

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Hixie
Copy link
Contributor

Hixie commented Oct 31, 2022

test-exempt: removing code

@ColdPaleLight ColdPaleLight requested a review from dnfield November 1, 2022 12:50
@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 1, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Nov 1, 2022

auto label is removed for flutter/engine, pr: 37109, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 1, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Nov 1, 2022

auto label is removed for flutter/engine, pr: 37109, due to Validations Fail.

@ColdPaleLight ColdPaleLight added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 2, 2022
@auto-submit auto-submit bot merged commit c05c8a8 into flutter:main Nov 2, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 2, 2022
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants