This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Changes to EditableState to be able to handle Framework text selection shortcuts #37097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
mdebbar
reviewed
Oct 28, 2022
Contributor
mdebbar
left a comment
mdebbar
left a comment
There was a problem hiding this comment.
Great tests!
Let's also add one to make sure EditingState.fromFrameworkMessage() sets the composing values to -1.
Could you also open the framework-side PR so reviewers can look at both PRs together?
8 tasks
Contributor
Author
@mdebbar Added that suggested tests and the PR in the description |
Co-authored-by: Mouad Debbar <[email protected]>
Co-authored-by: Mouad Debbar <[email protected]>
htoor3
force-pushed
the
text-edit-shift-issue-engine
branch
from
60c499e to
6d3c372
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 1, 2022
…rk text selection shortcuts (flutter/engine#37097)
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
…lection shortcuts (flutter#37097)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there's an issue in which keyboard shortcuts (shift + arrow keys) don't autoscroll on web inputs and textfields. Delegating these keyboard actions to the framework fixes this issue and allows for a more consistent UX for web.
As part of that change, the
EditableStateclass needs to be able to handle flipped base and extent offsets, as well as have sensible defaults for composing offsets.Part 1 fixes flutter/flutter#107707
Framework changes PR: flutter/flutter#114264
Pre-launch Checklist
///).