-
Notifications
You must be signed in to change notification settings - Fork 6k
[Impeller] Set resourceOptions/storageMode on MTLTextures created from MTLBuffers. #37073
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
It looks like the unit test failures are related. |
|
Yes, and failure means that the updates to run_test are enabling metal validation. |
|
Neat, I didn't think to enable this on a per test basis. |
|
These tests are passing on an M1 but not on the CI x64 machines, need to figure out whether we can suppor tthis API in that configuration or not. |
|
Oh goodness Iw as looking at the wrong test. |
|
Unfortunately, the updated env vars to run_tests.py do not trigger failures without this change. However, adding the ones that Xcode uses trigger many other failures that seem not quite right. |
|
I'm going to land this to at least get the existing tests working on development machines. Maybe we can figure out how to make this work across architectures and on CI separate from this patch. |
…reated from MTLBuffers. (flutter/engine#37073)
…reated from MTLBuffers. (flutter/engine#37073)
Fix flutter/flutter#114110
Enable metal validation when running impeller unittests .. or try to anyway.