Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Oct 27, 2022

Fix flutter/flutter#114110

Enable metal validation when running impeller unittests .. or try to anyway.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@zanderso
Copy link
Member

It looks like the unit test failures are related.

@dnfield
Copy link
Contributor Author

dnfield commented Oct 27, 2022

Yes, and failure means that the updates to run_test are enabling metal validation.

@chinmaygarde chinmaygarde changed the title Set resourceOptions/storageMode on MTLTextures created from MTLBuffers. [Impeller] Set resourceOptions/storageMode on MTLTextures created from MTLBuffers. Oct 27, 2022
@chinmaygarde
Copy link
Member

Neat, I didn't think to enable this on a per test basis.

@dnfield
Copy link
Contributor Author

dnfield commented Oct 27, 2022

These tests are passing on an M1 but not on the CI x64 machines, need to figure out whether we can suppor tthis API in that configuration or not.

@dnfield dnfield marked this pull request as draft October 27, 2022 22:15
@dnfield dnfield marked this pull request as ready for review October 27, 2022 23:02
@dnfield
Copy link
Contributor Author

dnfield commented Oct 28, 2022

Oh goodness Iw as looking at the wrong test.

@dnfield
Copy link
Contributor Author

dnfield commented Oct 28, 2022

Unfortunately, the updated env vars to run_tests.py do not trigger failures without this change. However, adding the ones that Xcode uses trigger many other failures that seem not quite right.

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 28, 2022
@dnfield
Copy link
Contributor Author

dnfield commented Oct 28, 2022

I'm going to land this to at least get the existing tests working on development machines. Maybe we can figure out how to make this work across architectures and on CI separate from this patch.

@auto-submit auto-submit bot merged commit cfb5324 into flutter:main Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

[Impeller] RendererTest.CanCreateCPUBackedTexture validation failure at head

3 participants