-
Notifications
You must be signed in to change notification settings - Fork 6k
[iOS] Not log callback cache info if cache is empty #36996
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Thanks for the contribution! Just waiting for sign-off from @Hixie to see if we're okay not adding a test for this. |
|
Ideally we would repurpose some of our integration tests over on the framework repo to trigger the condition that results in this output, and verify that the logs are entirely clear of extraneous messages. We have a few tests that check things like this already, at least on Android. cc @jmagman who may know precisely which tests would be best suited to use for this. |
|
I'm not familiar with how this cache works to know which tests might catch this, what are the cases where would it be empty? |
@jmagman Seems most cases of users should be empty, only when navigator restorable method use it , like https://github.com/flutter/flutter/blob/d9a2229babbc7e28cabd0ad42470c527a6cd9d3e/packages/flutter/lib/src/widgets/navigator.dart#L5386 and https://github.com/flutter/flutter/blob/d9a2229babbc7e28cabd0ad42470c527a6cd9d3e/packages/flutter/lib/src/widgets/navigator.dart#L4461 whitch calles |
chinmaygarde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though this is a verbose log, I don't think it adds any value. I'd be down to just removing it as it isn't actionable.
SGTM, @zhongwuzw can you remove the |
@jmagman Done. :) |
If we don't use callback cache, every time we start the app, the log prints "Runner[667:97662] [VERBOSE0:callback_cache.cc(136)] Could not parse callback cache, aborting restore", which may lead to misleading.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.