Let _debugCheckNotUsedAsOldLayer provide hashcode in addition to runtime type
#36985
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
The CI failure, "infra failed", does not look like a problem of my code indeed
|
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM, asked for a test excemption.
|
Also re-kicked the infra failure :) |
| assert( | ||
| !_debugWasUsedAsOldLayer, | ||
| 'Layer $runtimeType was previously used as oldLayer.\n' | ||
| 'Layer $runtimeType#${hashCode.toUnsigned(20).toRadixString(16).padLeft(5, '0')} was previously used as oldLayer.\n' |
There was a problem hiding this comment.
leave a comment here saying this should match shortHash in the framework?
|
This would ideally be tested on the framework side, to make sure the output matches what we expect from other messages (we have a special matcher that knows how to normalize this kind of hash code). That can't be in this PR, though. test-exempt: test needs to be in another repo |
dnfield
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 36985, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead. |
|
auto label is removed for flutter/engine, pr: 36985, due to Validations Fail. |
…tion to runtime type (flutter/engine#36985)
…tion to runtime type (flutter/engine#36985)
…ntime type (flutter#36985) * Update compositing.dart * Update compositing.dart * Update compositing.dart
4 participants
I see this assert fail when working on my own app today (unrelated to flutter_smooth; work on stable channel). With identity hashcode, we can surely know more about which layer violates.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.