Adds a release_candidate variable to DEPS. #36978
Conversation
|
This will be followed by a recipes change to set the variable to true on release candidate branches. |
| # for the web engine. | ||
| 'download_emsdk': False, | ||
|
|
||
| # For experimental features some dependencies may only be avaialable in the master/main |
|
|
||
| # For experimental features some dependencies may only be avaialable in the master/main | ||
| # channels. This variable is being set when CI is checking out the repository. | ||
| 'release_candidate': False, |
There was a problem hiding this comment.
I wonder if it would be better to have a "channel" variable, it's likely that down the road Windows ARM64 and RISCV SDKs will be on beta but not on stable.
There was a problem hiding this comment.
I can change the variable name however we don't have a good way to detect the channel. Flutter builds everything in release candidate branches and for new beta|stable releases we only know the channel when we push the release candidate branch to the channel branch.
Would it be confusing naming the variable channel and always setting to beta?
There was a problem hiding this comment.
Hmm, if it's only ever beta, it wouldn't help much. How would we know to have Windows ARM64 on beta but not on stable. It would be possible to determine what Dart channel is to be used from the Dart version. Would it help if the variable was dart_channel? We always CP a Dart release, and when that CP happens, maybe we can change the value of dart_channel to match the CP'ed version of Dart?
There was a problem hiding this comment.
Not sure how can we get that information without hardcoding it somewhere in the infra configs, any ideas?
|
My suggestion would be to build it into the "pick the the desired Dart
version for the release" tooling. On flutter/engine main it would always be
`dev`. On release candidate branches the Dart CP would change it together
with the Dart revision to `beta` or `stable`.
…On Tue, 25 Oct 2022, 20:07 godofredoc, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In DEPS
<#36978 (comment)>:
> @@ -30,6 +30,11 @@ vars = {
# for the web engine.
'download_emsdk': False,
+ # For experimental features some dependencies may only be avaialable in the master/main
+ # channels. This variable is being set when CI is checking out the repository.
+ 'release_candidate': False,
Not sure how can we get that information without hardcoding it somewhere
in the infra configs, any ideas?
—
Reply to this email directly, view it on GitHub
<#36978 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYRJBYBPXPBKD4KJJYZO73WFAOVNANCNFSM6AAAAAARNK52HM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
This is used to avoid trying to download experimental dependencies as part of the release candidate branches. Bug: flutter/flutter#113931
Wouldn't this fail for beta and stable if the cipd packages do not exist? or is the purpose to make it a no-op if the cipd package does not exist? |
godofredoc
added
the
autosubmit
4 participants
This is used to avoid trying to download experimental dependencies as part of the release candidate branches.
Bug: flutter/flutter#113931
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.