This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove deprecated TextInputClient scribble method code #36970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmc
commented
Oct 24, 2022
| XCTAssertEqual([textInputPlugin.activeView.selectionRects count], 1u); | ||
| } | ||
|
|
||
| - (void)testScribbleSetSelectionRectsTICFails { |
Contributor
Author
There was a problem hiding this comment.
Is this test useful, or should I get a text exemption?
Member
There was a problem hiding this comment.
I don't think this adds any value. This patch remove the deprecated stuff in a two-step transition. I think we should land this.
Contributor
There was a problem hiding this comment.
+1 we should just get an exempt.
chinmaygarde
approved these changes
Oct 27, 2022
| XCTAssertEqual([textInputPlugin.activeView.selectionRects count], 1u); | ||
| } | ||
|
|
||
| - (void)testScribbleSetSelectionRectsTICFails { |
Member
There was a problem hiding this comment.
I don't think this adds any value. This patch remove the deprecated stuff in a two-step transition. I think we should land this.
Contributor
Author
|
Checked with @Hixie on Discord and this needs no exemption since it is all deletions (otherwise the bought would ask for an exemption). |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 29, 2022
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up some old methods that were deprecated in #36642 and the framework is currently switching off in flutter/flutter#104128.
Depends on flutter/flutter#104128.