This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix a11y an Android #3694
Merged
Fix a11y an Android #3694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The core problem was multiplying matrices the wrong way around. While I was there I did some minor cleanup. I think that may have fixed another bug relating to A11Y turning on or off improperly, but since I never figured out the steps to reproduce, it's hard to tell. Fixes flutter/flutter#7205 Fixes flutter/flutter#10059 (maybe)
Contributor
Author
|
cc @tvolkert who had some ideas on how to test this |
Contributor
|
LGTM, but obviously testing would be very valuable once we figure out how to do it. |
Contributor
|
LGTM. I'll start an internal thread about testing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core problem was multiplying matrices the wrong way around.
While I was there I did some minor cleanup. I think that may have
fixed another bug relating to A11Y turning on or off improperly, but
since I never figured out the steps to reproduce, it's hard to tell.
Fixes flutter/flutter#7205
Fixes flutter/flutter#10059 (maybe)