[Impeller] Make validation errors fatal in non-release builds. #36812
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| '--std=ios-metal1.2', | ||
| '-mios-version-min=10.0', | ||
| ] | ||
| # if args.platform == 'ios-simulator': |
There was a problem hiding this comment.
Did you mean to leave this in?
There was a problem hiding this comment.
I uploaded this quickly to kick off a presubmit run before your patch landed so that I can verify that making the log FATAL will cause the scenario test to fail. I'll rebase and remove this when that check is finished.
chinmaygarde
changed the title
zanderso
force-pushed
the
iossim-metal-version
branch
from
48c6aa1 to
52bc047
Compare
|
Verified that tests fail after this patch, without the fix in #36809: |
zanderso
added
the
autosubmit
…113586) * 5357f814c Roll Skia from 584ec9885ca1 to 8c73a59cd417 (1 revision) (flutter/engine#36810) * 5c10a4421 [Impeller] Add docs to detail RenderDoc frame captures (flutter/engine#36815) * 8744c93c4 [Impeller] Make validation errors fatal in non-release builds. (flutter/engine#36812) * afcf153d2 Roll Fuchsia Linux SDK from GvWjlKsW1ybhJZzUp... to CW9-6BIlFFDbRCs-c... (flutter/engine#36816) * 93b86eb62 Roll Clang from 039b969b32b6 to a93d03310e2c (flutter/engine#36821)
2 participants
This ensures that the scenario tests with Impeller enabled will fail when there are validation errors like the ones fixed by #36809