[Impeller] Add WSI support for Vulkan on Linux and Windows #36762
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| } | ||
| if (!HasRequiredProperties(device)) { | ||
| VALIDATION_LOG << "Device doesn't have required properties."; | ||
| FML_LOG(ERROR) << "Device doesn't have required properties."; |
There was a problem hiding this comment.
these are no longer validation logs as there can be multiple physical devices and we don't need to fail early if one of them isn't valid.
There was a problem hiding this comment.
Perhaps just remove the log line entirely?
There are additional instance extensions that need to be enabled for this. Having any one of them is sufficient on each of these platforms. There were also some `VALIDATION_LOG`s that would fail in the process of picking a valid physical device, this would incorrectly exit early when there were multiple devices and a latter device is valid. Also improves logging for playground when glfw fails to get a surface.
iskakaushik
force-pushed
the
wsi-support-linux
branch
from
88701e4 to
4523351
Compare
|
After #36776 lands we can see things rendering on Linux.
Tested on WSL - Ubuntu. |
| } | ||
| if (!HasRequiredProperties(device)) { | ||
| VALIDATION_LOG << "Device doesn't have required properties."; | ||
| FML_LOG(ERROR) << "Device doesn't have required properties."; |
There was a problem hiding this comment.
Perhaps just remove the log line entirely?
2 participants
There are additional instance extensions that need to be enabled for this. Having any one of them is sufficient on each of these platforms. There were also some
VALIDATION_LOGs that would fail in the process of picking a valid physical device, this would incorrectly exit early when there were multiple devices and a latter device is valid.Also improves logging for playground when glfw fails to get a surface.