Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Specify correct YUV color space for Darwin YUV external textures #36709

Merged
auto-submit merged 5 commits into from
Oct 12, 2022
Merged

Specify correct YUV color space for Darwin YUV external textures #36709

auto-submit merged 5 commits into from
Oct 12, 2022

Conversation

@ColdPaleLight
Copy link
Member

@ColdPaleLight ColdPaleLight commented Oct 11, 2022 •
edited
Loading

fix flutter/flutter#113256

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added embedder Related to the embedder API platform-macos labels Oct 11, 2022
@ColdPaleLight ColdPaleLight requested review from chinmaygarde and iskakaushik and removed request for chinmaygarde October 11, 2022 03:35
@jmagman
Copy link
Member

jmagman commented Oct 11, 2022

@brianosman I see you worked on #23153 a few years ago, are you able to give this a once-over sanity check?

@brianosman
Copy link
Contributor

brianosman commented Oct 11, 2022

Yes, this looks correct.

@ColdPaleLight ColdPaleLight changed the title Specify correct YUV color space for iOS YUV external textures Specify correct YUV color space for Darwin YUV external textures Oct 12, 2022
@ColdPaleLight ColdPaleLight added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 12, 2022
@auto-submit auto-submit bot merged commit c4da2d8 into flutter:main Oct 12, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 12, 2022
@engine-flutter-autoroll
c4da2d890 Specify correct YUV color space for Darwin YUV external tex…
8b06eb3 
…tures (flutter/engine#36709)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde chinmaygarde is a code owner

1 more reviewer

@brianosman brianosman brianosman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App embedder Related to the embedder API platform-macos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider specifying correct YUV color space for iOS YUV external textures

3 participants

@ColdPaleLight @jmagman @brianosman