Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Stop compiling iOS with bitcode #36596

Merged
auto-submit merged 3 commits into from
Oct 4, 2022
Merged

Stop compiling iOS with bitcode #36596

auto-submit merged 3 commits into from
Oct 4, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Oct 4, 2022 •
edited
Loading

Deprecate --bitcode flags without removing them, until recipe can be updated. This does not cover removing the strip_bitcode logic #36510.

https://ci.chromium.org/p/flutter/builders/try/Mac%20iOS%20Engine%20Release/628

Flutter projects no longer build with bitcode: flutter/flutter#111776 and flutter/flutter#107883

Part of flutter/flutter#107884
Recipe side at https://flutter-review.googlesource.com/c/recipes/+/34583

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Oct 4, 2022
@flutter-dashboard flutter-dashboard bot added the embedder Related to the embedder API label Oct 4, 2022
jmagman
jmagman commented Oct 4, 2022
View reviewed changes
ci/builders/mac_ios_engine.json
"os=Mac-12"
],
"gn": [
"--bitcode",
Copy link
Member Author

@jmagman jmagman Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1 recipe change at https://flutter-review.googlesource.com/c/recipes/+/34583

@jmagman jmagman marked this pull request as ready for review October 4, 2022 21:37
@jmagman jmagman mentioned this pull request Oct 4, 2022
Closed
@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 4, 2022
@auto-submit auto-submit bot merged commit 0d1330b into flutter:main Oct 4, 2022
@jmagman jmagman deleted the remove-bitcode branch October 4, 2022 22:00
This was referenced Oct 4, 2022
Merged
Merged
cbracken
cbracken reviewed Oct 4, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jmagman jmagman mentioned this pull request Oct 5, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 5, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 5, 2022
@engine-flutter-autoroll
0d1330b26 Stop compiling iOS with bitcode (flutter/engine#36596)
02f759b
@jmagman jmagman mentioned this pull request Oct 6, 2022
Merged
8 tasks
@jmagman jmagman added the blog Items that should be included in a blog label Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@godofredoc godofredoc Awaiting requested review from godofredoc

2 more reviewers

@cbracken cbracken cbracken left review comments

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

autosubmit Merge PR when tree becomes green via auto submit App blog Items that should be included in a blog embedder Related to the embedder API platform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @cbracken @zanderso