Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Roll ANGLE, vulkan-deps, and shaderc #36389

Merged
loic-sharma merged 1 commit into from
Nov 1, 2022
Merged

Roll ANGLE, vulkan-deps, and shaderc #36389

loic-sharma merged 1 commit into from
Nov 1, 2022

Conversation

@loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Sep 23, 2022 •
edited
Loading

This change updates ANGLE to a version that contains angle#3906325, which fixes the COM error reported in flutter/flutter#110948. This also updates vulkan-deps and shaderc as these are dependencies of ANGLE.

Part of flutter/flutter#110948

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@loic-sharma loic-sharma changed the title Roll ANGLE, vulkan-deps, and shaderc [WIP] Roll ANGLE, vulkan-deps, and shaderc Sep 27, 2022
loic-sharma
loic-sharma commented Sep 27, 2022
View reviewed changes
loic-sharma
loic-sharma commented Oct 4, 2022
View reviewed changes
@loic-sharma loic-sharma mentioned this pull request Oct 14, 2022
Merged
@skia-gold
Copy link

skia-gold commented Oct 27, 2022

Gold has detected about 16 new digest(s) on patchset 9.
View them at https://flutter-engine-gold.skia.org/cl/github/36389

@loic-sharma loic-sharma changed the title [WIP] Roll ANGLE, vulkan-deps, and shaderc Roll ANGLE, vulkan-deps, and shaderc Oct 27, 2022
@loic-sharma loic-sharma marked this pull request as ready for review October 27, 2022 23:09
loic-sharma
loic-sharma commented Oct 27, 2022
View reviewed changes
tools/gn
get_host_os() == 'win'):
# Do not build unnecessary parts of the ANGLE tree.
gn_args['angle_build_all'] = False
gn_args['angle_has_astc_encoder'] = False
Copy link
Member Author

@loic-sharma loic-sharma Oct 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ANGLE added a new dependency that we don't need. This opts-out of it.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Oct 28, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

cbracken
cbracken approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@loic-sharma loic-sharma force-pushed the roll_angle_2 branch 2 times, most recently from 7966316 to 1ce739a Compare November 1, 2022 17:24
@Hixie
Copy link
Contributor

Hixie commented Nov 1, 2022

test-exempt: rolling dependencies

@loic-sharma loic-sharma mentioned this pull request Nov 1, 2022
Closed
@loic-sharma loic-sharma merged commit 36b1ae3 into flutter:main Nov 1, 2022
@loic-sharma loic-sharma deleted the roll_angle_2 branch November 1, 2022 22:14
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 2, 2022
@engine-flutter-autoroll
36b1ae3a7 Roll ANGLE, vulkan-deps, and shaderc (flutter/engine#36389)
7055a29
@zanderso zanderso mentioned this pull request Nov 2, 2022
Closed
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
@loic-sharma @schwa423
Roll ANGLE, vulkan-deps, and shaderc (flutter#36389)
e0b3fca 
This change updates ANGLE to a version that contains [angle#3906325](https://chromium-review.googlesource.com/c/angle/angle/+/3906325), which fixes the COM error reported in  flutter/flutter#110948. This also updates vulkan-deps and shaderc as these are dependencies of ANGLE.

Part of flutter/flutter#110948
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stuartmorgan-g stuartmorgan-g Awaiting requested review from stuartmorgan-g

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

4 more reviewers

@cbracken cbracken cbracken approved these changes

@dnfield dnfield dnfield approved these changes

@a-wallen a-wallen a-wallen approved these changes

@yaakovschectman yaakovschectman yaakovschectman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@loic-sharma @skia-gold @Hixie @chinmaygarde @cbracken @dnfield @a-wallen @yaakovschectman