This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] enable dart null safety for fuchsia .dart files (part 2) #36303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akbiggs
approved these changes
Sep 21, 2022
Contributor
Author
|
The failing tests seem due to an infra issue rather than any changes I made. Tried re-running them several times with no luck. Will need to investigate the issue |
Contributor
|
Yeah. Let's hold off on merging for now, there's another flake that appears to be caused by Fuchsia code going on right now (unrelated to the infra issue you just posted about). We can open a separate chat thread for the infra issue. |
Contributor
|
If you rebase on upstream it should be fixed now (CQ runs from the commit you're based on, not HEAD). |
bergkampben
force-pushed
the
null_safe_3
branch
from
2704010 to
1cbfb44
Compare
bergkampben
force-pushed
the
null_safe_3
branch
from
1cbfb44 to
a549155
Compare
11 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 23, 2022
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables null safety in compiler.dart and dart_profiler_symbols.dart
Contributes to flutter/flutter#110016, flutter/flutter#110020
No changes were required for these directories besides upgrading the SDK version
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.