Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix create macos framework. #36163

Merged
auto-submit merged 6 commits into from
Sep 16, 2022
Merged

Fix create macos framework. #36163

auto-submit merged 6 commits into from
Sep 16, 2022

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Sep 15, 2022

Subprocess.run does not work properly with the python version installed in the bots.

Bug: flutter/flutter#81855

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Move subprocess.run to popen.
bf5cec7 
subprocess.run does not work properly on the python version used by the
bots.

Bug: flutter/flutter#81855
@godofredoc
Format file.
6d8c2d1
@godofredoc
Add logic to regenerate symlinks.
403be98
@chinmaygarde chinmaygarde added the Work in progress (WIP) Not ready (yet) for review! label Sep 15, 2022
@godofredoc godofredoc removed the Work in progress (WIP) Not ready (yet) for review! label Sep 16, 2022
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 16, 2022
@auto-submit auto-submit bot merged commit 70cf481 into flutter:main Sep 16, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 16, 2022
@engine-flutter-autoroll
70cf48157 Fix create macos framework. (flutter/engine#36163)
12ec00b
Oleh-Sv pushed a commit to Oleh-Sv/engine that referenced this pull request Sep 28, 2022
@godofredoc
Fix create macos framework. (flutter#36163)
40b0c82
@godofredoc godofredoc deleted the fix_createmacos branch January 12, 2024 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jmagman jmagman Awaiting requested review from jmagman

1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @zanderso @chinmaygarde