This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add Radius.clamp and Radius.clampValues
#36106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gspencergoog
force-pushed
the
add_clamp_radius
branch
from
4cb86ce to
ff54384
Compare
flutter-dashboard
bot
added
the
platform-web
mdebbar
approved these changes
Sep 12, 2022
gspencergoog
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 13, 2022
cfontas
pushed a commit
to cfontas/engine
that referenced
this pull request
Sep 14, 2022
itsjustkevin
pushed a commit
to itsjustkevin/engine
that referenced
this pull request
Sep 20, 2022
itsjustkevin
pushed a commit
to itsjustkevin/engine
that referenced
this pull request
Sep 20, 2022
itsjustkevin
added a commit
that referenced
this pull request
Sep 21, 2022
* Add `Radius.clamp` and `Radius.clampValues` (#36106) * Build CanvasKit in the Flutter Engine (#32510) * Clamp `RRect` radii when deflating, assert on negative radii (#36062) Co-authored-by: Greg Spencer <[email protected]> Co-authored-by: Harry Terkelsen <[email protected]>
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds two clamping functions for the
Radiusclass so that it is easier to clamp values for use when given values toRRect, which I am hoping to convert toassertwhen negative radii are given to it, since they are not really meaningful in anRRect, while they do sometimes make sense when doing calculations with radii.Related Issues
Tests