This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Clamp RRect radii when deflating, assert on negative radii
#36062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gspencergoog
force-pushed
the
clamp_rrect_radii
branch
3 times, most recently
from
8c3c2db to
fe04609
Compare
gspencergoog
changed the title
RRect radii when deflating, assert on negative radii
gspencergoog
force-pushed
the
clamp_rrect_radii
branch
2 times, most recently
from
fe09c32 to
cce13a5
Compare
|
Gold has detected about 1 new digest(s) on patchset 8. |
gspencergoog
force-pushed
the
clamp_rrect_radii
branch
from
cce13a5 to
20da08e
Compare
flutter-dashboard
bot
added
the
platform-web
gspencergoog
commented
Sep 13, 2022
| "//flutter/lib/ui/isolate_name_server.dart", | ||
| "//flutter/lib/ui/key.dart", | ||
| "//flutter/lib/ui/lerp.dart", | ||
| "//flutter/lib/ui/math.dart", |
Contributor
Author
There was a problem hiding this comment.
This file was added in #36106, but I forgot to add it here. To be honest, I have no idea why it didn't blow up the framework build, but it didn't. Anyhow, adding it in now so that we can finish moving clampDouble into dart:ui.
gspencergoog
requested review from
goderbauer
and removed request for
yjbanov
goderbauer
approved these changes
Sep 14, 2022
| assert(blRadiusX != null), | ||
| assert(blRadiusY != null); | ||
| assert(blRadiusY != null), | ||
| assert(tlRadiusX >= 0), |
Member
There was a problem hiding this comment.
Maybe mention this in the docs for the public constructors that feed into this?
gspencergoog
force-pushed
the
clamp_rrect_radii
branch
from
d97b7ee to
e5529e5
Compare
gspencergoog
force-pushed
the
clamp_rrect_radii
branch
from
e5529e5 to
c52f063
Compare
gspencergoog
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 15, 2022
itsjustkevin
pushed a commit
to itsjustkevin/engine
that referenced
this pull request
Sep 21, 2022
itsjustkevin
added a commit
that referenced
this pull request
Sep 21, 2022
* Add `Radius.clamp` and `Radius.clampValues` (#36106) * Build CanvasKit in the Flutter Engine (#32510) * Clamp `RRect` radii when deflating, assert on negative radii (#36062) Co-authored-by: Greg Spencer <[email protected]> Co-authored-by: Harry Terkelsen <[email protected]>
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding clamping to
RRectradii when deflating, and asserting that supplied radii aren't negative, since having negative radii was causing some rendering artifacts.This is the right place to do it, rather than higher in the stack, (e.g. as was necessary in flutter/flutter#106849).
Also, added a reference to
math.dartin thedart_ui.gnifile that was missed in #36106Related PRs:
Related Issues
Tests