This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Enable native Windows on Arm build #35962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please coordinate with #35986. |
8 tasks
Contributor
Author
Member
|
This seems reasonable to me (one the presubmits are fixed). @cbracken, do you have reservations about this approach? |
cbracken
reviewed
Sep 15, 2022
cbracken
approved these changes
Sep 15, 2022
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
lgtm. I've applied a small formatting fix that should get CI to pass.
stuartmorgan-g
approved these changes
Sep 20, 2022
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with a nit and a question. Looks like main will need to be merged in again for CI.
Contributor
Author
|
I just updated branch with changes (+ integrated formatting fix in concerned commit). |
cbracken
reviewed
Sep 21, 2022
Contributor
Author
|
Fixed issue with android build (from windows), and rebased on top of main. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 23, 2022
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
Linaro [Windows on Arm](https://www.linaro.org/windows-on-arm/) team is working to enable projects for this new platform. Lately, we have been interested in Dart/Flutter. This PR enables building natively flutter components (exe + dll) for windows on arm. It solves this issue (flutter/flutter#62597) partially, by starting with native build.
8 tasks
17 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linaro Windows on Arm team is working to enable projects for this new platform.
Lately, we have been interested in Dart/Flutter.
This PR enables building natively flutter components (exe + dll) for windows on arm.
It solves this issue (flutter/flutter#62597) partially, by starting with native build.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.