This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Remove serve.sh #35895
Merged
[fuchsia] Remove serve.sh #35895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script is unreliable. Context from @chaselatta: ``` serve.sh will still suffer from instability. The reason is that the flutter/engine repo is using the fuchsia.com host for all of its packages. When that script runs it tries to connect to the target and rewrite some rules so that it resolves fuchsia.com to engine which is what is being served locally. If you later call serve from fuchsia.git it will do the same thing and overwrite your local repo rewrite rules and serve the runner that is being published from fuchsia.git. There are some changes to ffx which allow you to better set rewrite rules via the --alias flag which would fix this problem. The bazel sdk doesn't suffer from this because we don't use the fuchsia.com repo name and thus don't have collisions. I think the best solution here is to stop using fuchsia.com when referencing the flutter runner but that is a pretty large change. ``` We're migrating to the Bazel SDK at fuchsia.googlesource.com/flutter-embedder so we'll gain the benefits of package serving then.
chaselatta
approved these changes
Sep 7, 2022
Member
|
From PR triage: This is blocked on the tree closure @ flutter/flutter#111193 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 9, 2022
cfontas
pushed a commit
to cfontas/engine
that referenced
this pull request
Sep 14, 2022
This script is unreliable. Context from @chaselatta: ``` serve.sh will still suffer from instability. The reason is that the flutter/engine repo is using the fuchsia.com host for all of its packages. When that script runs it tries to connect to the target and rewrite some rules so that it resolves fuchsia.com to engine which is what is being served locally. If you later call serve from fuchsia.git it will do the same thing and overwrite your local repo rewrite rules and serve the runner that is being published from fuchsia.git. There are some changes to ffx which allow you to better set rewrite rules via the --alias flag which would fix this problem. The bazel sdk doesn't suffer from this because we don't use the fuchsia.com repo name and thus don't have collisions. I think the best solution here is to stop using fuchsia.com when referencing the flutter runner but that is a pretty large change. ``` We're migrating to the Bazel SDK at fuchsia.googlesource.com/flutter-embedder so we'll gain the benefits of package serving then.
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
This script is unreliable. Context from @chaselatta: ``` serve.sh will still suffer from instability. The reason is that the flutter/engine repo is using the fuchsia.com host for all of its packages. When that script runs it tries to connect to the target and rewrite some rules so that it resolves fuchsia.com to engine which is what is being served locally. If you later call serve from fuchsia.git it will do the same thing and overwrite your local repo rewrite rules and serve the runner that is being published from fuchsia.git. There are some changes to ffx which allow you to better set rewrite rules via the --alias flag which would fix this problem. The bazel sdk doesn't suffer from this because we don't use the fuchsia.com repo name and thus don't have collisions. I think the best solution here is to stop using fuchsia.com when referencing the flutter runner but that is a pretty large change. ``` We're migrating to the Bazel SDK at fuchsia.googlesource.com/flutter-embedder so we'll gain the benefits of package serving then.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script is unreliable. Context from @chaselatta:
We're migrating to the Bazel SDK at
https://fuchsia.googlesource.com/flutter-embedder so we'll gain the benefits of
package serving then.