This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Workflow scripts. #35822
Merged
[fuchsia] Workflow scripts. #35822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akbiggs
force-pushed
the
fuchsia-workflow
branch
from
b715954 to
7035158
Compare
- Adds a new script to build and copy Flutter on Fuchsia. - Rename sync_to_fuchsia.sh to checkout_fuchsia_revision.sh so it's more clear what git action is being performed (checkout instead of rebase). Update this script to `gclient sync -D` afterwards since not doing that will lead to subtle build issues. This script is only used by workflow docs, not infra, so renaming it is fine. Once submitted I will update the documentation.
akbiggs
force-pushed
the
fuchsia-workflow
branch
from
7035158 to
c3b258b
Compare
lin-erik
reviewed
Aug 31, 2022
|
|
||
| echo "Done. You can now build Fuchsia with your Flutter Engine changes by running:" | ||
| echo ' cd $FUCHSIA_DIR' | ||
| # TODO(akbiggs): I'm not sure what example to give for arm64. |
Contributor
There was a problem hiding this comment.
Does anyone use workstation_eng.arm64?
Contributor
Author
There was a problem hiding this comment.
It seems to be broken for me, opened fxb/108361.
lin-erik
approved these changes
Aug 31, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 31, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 31, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 1, 2022
…110727) * 5a1a855b2 Roll Clang from 41d4067d0b7c to 039b969b32b6 (flutter/engine#35840) * 3a1d6a9b0 Roll Skia from e0b87738eca7 to 45fe3b5a6710 (9 revisions) (flutter/engine#35841) * fb067eab7 [Impeller] Compute shader support (flutter/engine#35750) * a53384841 Roll Dart SDK from 5a2737b71877 to fec63626f078 (2 revisions) (flutter/engine#35844) * 3dc4e4971 roll CanvasKit to 0.36.1 (attempt 2) (flutter/engine#35839) * 9b14b25eb Reland: Adds a reusable FragmentShader (flutter/engine#35846) * ac34d3e63 [fuchsia] Workflow scripts. (flutter/engine#35822) * f0f8d10b8 Revert "Roll Dart SDK from 5a2737b71877 to fec63626f078 (2 revisions) (#35844)" (flutter/engine#35849)
akbiggs
added a commit
to akbiggs/engine
that referenced
this pull request
Sep 2, 2022
- Adds a new script to build and copy Flutter on Fuchsia. - Rename sync_to_fuchsia.sh to checkout_fuchsia_revision.sh so it's more clear what git action is being performed (checkout instead of rebase). Update this script to `gclient sync -D` afterwards since not doing that will lead to subtle build issues. This script is only used by workflow docs, not infra, so renaming it is fine. Once submitted I will update the documentation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync_to_fuchsia.shtocheckout_fuchsia_revision.shso it's more clear what git action is being performed (checkout
instead of rebase). Update this script to
gclient sync -Dafterwardssince not doing that will lead to subtle build issues. This script
is only used by workflow docs, not infra, so renaming it is fine.
Once submitted I will update the documentation.
Tested: Ran
test_build_and_copy_to_fuchsia.shlocally, all commands pass.