This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Image shader dispose #35640
Merged
Image shader dispose #35640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
zanderso
approved these changes
Aug 23, 2022
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
Won't web need a debugDisposed + test as well?
Contributor
Author
|
Yeah I missed that on web. Will fix. |
dnfield
added
the
autosubmit
zanderso
reviewed
Aug 23, 2022
| expect(shader.debugDisposed, true); | ||
| } | ||
|
|
||
| image.dispose(); |
Member
There was a problem hiding this comment.
A test that tries to attach a disposed shader to a Paint and then use the Paint could be useful. It should not segfault or abort, and should rather throw a Dart exception.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 23, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 23, 2022
…110121) * 94f97c337 Roll Skia from b91dbe274717 to 94602de608e0 (4 revisions) (flutter/engine#35634) * 6ec08c50e Roll Skia from 94602de608e0 to 8c32b0148770 (7 revisions) (flutter/engine#35636) * 9195b7a2f Roll Dart SDK from 03506589f2d0 to c064b9bacc4d (1 revision) (flutter/engine#35637) * f7ec70782 Roll Skia from 8c32b0148770 to a9a05d0bf0c5 (3 revisions) (flutter/engine#35639) * 15cf53acc Image shader dispose (flutter/engine#35640) * ee3cd0d8a Roll Skia from a9a05d0bf0c5 to 147232a3cebc (2 revisions) (flutter/engine#35641) * 5f53ee3b2 [Impeller] Use linear sampling for reads in the texture atlas (flutter/engine#35618) * 4ff7f7b9a Roll Fuchsia Mac SDK from JocShsJvXYeSVjgvW... to Es8SXkqDOYZ5dgYTq... (flutter/engine#35642) * 565cc861e Roll Skia from 147232a3cebc to cc63d5dd13b6 (1 revision) (flutter/engine#35643) * b4af69f02 Roll Dart SDK from c064b9bacc4d to 3042d6196824 (1 revision) (flutter/engine#35644) * 8cc02dc73 Roll Skia from cc63d5dd13b6 to a4744aa054cf (2 revisions) (flutter/engine#35645)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image shaders can contain images and should be disposed.
Fixes flutter/flutter#82832
Once this lands we should update vector_graphics to dispose the image shaders it creates.