This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Implement ui.Picture.toImage() #35633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColdPaleLight
commented
Aug 30, 2022
ColdPaleLight
changed the title
Member
Author
|
Would like to get some comments, cc @dnfield @chinmaygarde @jonahwilliams |
dnfield
reviewed
Aug 31, 2022
| const Delegate& GetDelegate() { return delegate_; } | ||
|
|
||
| private: | ||
| const Delegate& delegate_; |
Contributor
There was a problem hiding this comment.
FML_DISALLOW_COPY_AND_ASSIGN(SnapshotController)
dnfield
reviewed
Aug 31, 2022
|
|
||
| namespace flutter { | ||
|
|
||
| sk_sp<DlImage> SnapshotControllerImpeller::MakeRasterSnapshot( |
Contributor
There was a problem hiding this comment.
This method seems like it should be guarded by the GPU sync switch...
dnfield
reviewed
Aug 31, 2022
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
Overall looks good, would like Chinmay or Jason to get a chance to have a look at it too.
chinmaygarde
approved these changes
Sep 1, 2022
jason-simmons
approved these changes
Sep 1, 2022
Contributor
|
Can we autosubmit this, or are there additional reviewers that should take a look? |
Member
Author
I think we can autosubmit it. |
ColdPaleLight
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 2, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix flutter/flutter#104718
Add a class
SnapshotControllerfor make snapshot, subclassSnapshotControllerSkiaandSnapshotControllerImpellerto implement the function. In addition, the API ofSnapshotDelegate:: MakeRasterSnapshotwas modified, the parameterdraw_callbackwas replaced bydisplay_listI guess Impeller's implementation doesn't need to generate a raster image, right?
Pre-launch Checklist
writing and running engine tests.
///).